[SOLVED] {line_options_xxx} in ODT files broke

bvgeleuken · March 15, 2019, 10:01pm

In Dolibarr 8.x the use of {line_options_xxx} in ODT files for proposals, orders and shipment works fine. After upgrading to 9.0.1 none of the ODT templates work anymore.
{line_options_xxx} isn’t filled out anymore

EDIT: Thanks to ksar:
Code changed since V9

So up to V8 use
{line_options_xxxx}
Above V9 use
{line_product_options_xxxx}

ksar · March 18, 2019, 2:03pm

Hi,

Open in Github : https://github.com/Dolibarr/dolibarr/issues/10521

bvgeleuken · March 21, 2019, 8:51pm

I know. I added the issue but I can not see if it has been assigned for resolving.
Therefore I hoped to get some solutions form the forum.

h6585 · March 22, 2019, 5:32am

Try typing out the {line_options_xxx} in the ODT file again and uploading the same.

ksar · March 22, 2019, 10:33am

Hi,

You mean it is working for you ?

bvgeleuken · March 22, 2019, 11:27am

No result.
{line_options_xxx} is not filled out.

h6585 · March 22, 2019, 12:03pm

{object_options_xxx} is working fine for me on Dolibarr 9.0.1

h6585 · March 22, 2019, 12:07pm

Try testing out by defining a new line options and inserting that field in your ODT. This would at least help in ruling out if the option is working altogether or if there is a bug

ksar · March 22, 2019, 12:34pm

Hi,

I have just test on my 9.0.1 and it is working great.

Could you please send a screenshot of the extrafield configuration and the odt file ?

Thanks.

bvgeleuken · March 22, 2019, 1:00pm

Here are the 9.0.1 screenshots

I added a new extra field in the products.
Doesn’t work either

Pièces jointes :

Screenshot2019-03-22at13.57.502.png (381 KB)

Screenshot2019-03-22at13.57.262.png (218 KB)

ksar · March 22, 2019, 5:51pm

I see nothing attached…

bvgeleuken · March 23, 2019, 7:40am

Second attempt

ksar · March 23, 2019, 9:09am

Hi,

THis is completely normal that it doesn’t work.
You have created your extrafield on product.
And you try to display it as it was a line delivery extrafield

Impossible !

bvgeleuken · March 23, 2019, 10:08am

Same template but used in Dolibarr 8.0.4
So where is impossible now!

ksar · March 23, 2019, 12:59pm

The extrafield configuration is different, with the screens above it should not work.
You have other extra field configured

bvgeleuken · March 23, 2019, 1:51pm

Thanks for your help.
But it’s exactly the same template
But in an earlier reply som e one asked to add a new field and use that one in the template to exclude that it was my extra filed configuration.
That’s why there is an extra field called test and I used that one in the template.

Other than that it is the exact same configuration and template

ksar · April 2, 2019, 1:08pm

HI,

I finally find some times to analyse your case.

After a review of the code there is a change between V8 and V9 :
V8 : https://github.com/Dolibarr/dolibarr/blob/8.0/htdocs/core/class/commondocgenerator.class.php#L550
V9 : https://github.com/Dolibarr/dolibarr/blob/9.0/htdocs/core/class/commondocgenerator.class.php#L580

So the Product Extra field of a line changed from {line_xxxx} to {line_product_xxxx}

Could you try ?

bvgeleuken · April 2, 2019, 2:21pm

Hi,

First of all, thanks for helping me out.

I change {line_options_xxx} to {line_product_xxx} where xxx is the name of the attribute code --> no result
Then I change {line_options_xxx} to {line_product_options_xxx} where xxx is the name of the attribute code --> no result

ksar · April 2, 2019, 2:24pm

HI,

Just to be sure, you have done it on a V9 ?

ksar · April 3, 2019, 10:00am

Hi,

I have just made the test and I confirm that if you have a product extrafiled defined and that you use the product on a proposal, on the ODT file the {line_product_options_xxxx} is working !

So up to V8 use {line_options_xxxx}
Above V9 use [code]
{line_product_options_xxxx}[/code