Margin rate and Mark rate show wrong formula

Using my Dolibarr Financial modules
1

Hi,

So far as I remember, the Profit Margin (in this case is Margin rate) formula supposed to be:

(Selling Price - Buying Price) / Selling Price

and Markup rate is using different formula: (Selling Price - Buying Price) / Buying Price)

2022-08-11 - 13.00.21.283
2022-08-11 - 13.00.21.283776×107 7.7 KB

2022-08-11 - 13.00.33.740
2022-08-11 - 13.00.33.7401237×112 8.21 KB

From the picture above it’s look like the percentage number are swapped.

I already changed code in some files in margin module but somehow it’s still not worked.

2

Finally, I change some text in htdocs/margin/admin/margin.php and htdocs/langs/en_US/margins.lang to fit my needs.

Thanks

3

Hello,
Please share your findings

4

hello, i disagree with your formulas; they are the opposite

5

This is my reference for Profit Margin and Markup formula:

Profit Margin = (Revenue - Cost) / Revenue
Markup = (Revenue - Cost) / Cost

https://personalmba.com/profit-margin/