Member Contributions - workflow with invoice stumbles

kreideholer · November 16, 2025, 4:16pm

Hi Jon,

thank you for your feedback. To avoid any misunderstandings: I haven’t made any changes or additions to the source code yet. Rather, I’m trying to figure out why the invoice isn’t containing the desired payment information from the third party, even though a look at the current source code in branch 20.0 suggests it should be.

I’m referring to the file htdocs/adherents/class/adherent.class.php.

Starting at line 1892, the payment terms of the linked third party are read.

github.com/Dolibarr/dolibarr

htdocs/adherents/class/adherent.class.php

d028d0d81


      
          					$paymenttermstatic = new PaymentTerm($this->db);
          					$invoice->cond_reglement_id = $paymenttermstatic->getDefaultId();
          					if (empty($invoice->cond_reglement_id)) {
          						$error++;
          						$this->error = 'ErrorNoPaymentTermRECEPFound';
          						$this->errors[] = $this->error;
          					}
          				}
          				$invoice->socid = $this->fk_soc;
          				// set customer's payment bank account on the invoice
          				if (!empty($customer->fk_account)) {
          					$invoice->fk_account = $customer->fk_account;
          				} elseif (getDolGlobalString('FACTURE_RIB_NUMBER')) {
          					// set default bank account from invoice module settings
          					$invoice->fk_account = (int) getDolGlobalString('FACTURE_RIB_NUMBER');
          				}
          				//set customer's payment method on the invoice
          				if (!empty($customer->mode_reglement_id)) {
          					$invoice->mode_reglement_id = $customer->mode_reglement_id;
          				}
          				//$invoice->date = $datesubscription;

The invoice is created at line 1911.

github.com/Dolibarr/dolibarr

htdocs/adherents/class/adherent.class.php

d028d0d81


      
          				}
          				//$invoice->date = $datesubscription;
          				$invoice->date = dol_now();
          
          				// Possibility to add external linked objects with hooks
          				$invoice->linked_objects['subscription'] = $subscriptionid;
          				if (GETPOSTISARRAY('other_linked_objects')) {
          					$invoice->linked_objects = array_merge($invoice->linked_objects, GETPOST('other_linked_objects', 'array:int'));
          				}
          
          				$result = $invoice->create($user);
          				if ($result <= 0) {
          					$this->error = $invoice->error;
          					$this->errors = $invoice->errors;
          					$error++;
          				} else {
          					$this->invoice = $invoice;
          				}
          			}
          
          			if (!$error) {

The invoice is then validated at line 1944

github.com/Dolibarr/dolibarr

htdocs/adherents/class/adherent.class.php

d028d0d81


      
          				$result = $invoice->addline($label, 0, 1, $vattouse, 0, 0, $idprodsubscription, 0, $datesubscription, '', 0, 0, 0, 'TTC', $amount, 1);
          				if ($result <= 0) {
          					$this->error = $invoice->error;
          					$this->errors = $invoice->errors;
          					$error++;
          				}
          			}
          
          			if (!$error) {
          				// Validate invoice
          				$result = $invoice->validate($user);
          				if ($result <= 0) {
          					$this->error = $invoice->error;
          					$this->errors = $invoice->errors;
          					$error++;
          				}
          			}
          
          			if (!$error) {
          				// TODO Link invoice with subscription ?
          			}

The creation of the PDF document of the invoice is called at line 2030.

github.com/Dolibarr/dolibarr

htdocs/adherents/class/adherent.class.php

d028d0d81


      
          				if (getDolGlobalInt('MAIN_MULTILANGS') && empty($newlang)) {
          					$newlang = $customer->default_lang;
          				}
          				if (!empty($newlang)) {
          					$outputlangs = new Translate("", $conf);
          					$outputlangs->setDefaultLang($newlang);
          				}
          				// Generate PDF (whatever is option MAIN_DISABLE_PDF_AUTOUPDATE) so we can include it into email
          				//if (!getDolGlobalString('MAIN_DISABLE_PDF_AUTOUPDATE'))
          
          				$invoice->generateDocument($invoice->model_pdf, $outputlangs);
          			}
          		}
          
          		if ($error) {
          			return -1;
          		} else {
          			return 1;
          		}
          	}

All of the above actions are called within the function public function subscriptionComplementaryActions.

This function itself is called from within the file htdocs/adherents/subscription.php, see line 321.

github.com/Dolibarr/dolibarr

htdocs/adherents/subscription.php

e5480945b


      
          
          		// Create subscription
          		$crowid = $object->subscription($datesubscription, $amount, $accountid, $operation, $label, $num_chq, $emetteur_nom, $emetteur_banque, $datesubend);
          		if ($crowid <= 0) {
          			$error++;
          			$errmsg = $object->error;
          			setEventMessages($object->error, $object->errors, 'errors');
          		}
          
          		if (!$error) {
          			$result = $object->subscriptionComplementaryActions($crowid, $option, $accountid, $datesubscription, $paymentdate, $operation, $label, $amount, $num_chq, $emetteur_nom, $emetteur_banque);
          			if ($result < 0) {
          				$error++;
          				setEventMessages($object->error, $object->errors, 'errors');
          			} else {
          				// If an invoice was created, it is into $object->invoice
          			}
          		}
          
          		if (!$error) {
          			$db->commit();

The email notification is then called there on line 341. Attaching the generated PDF file of the invoice is described starting on line 397.

github.com/Dolibarr/dolibarr

htdocs/adherents/subscription.php

e5480945b


      
          					$substitutionarray = getCommonSubstitutionArray($outputlangs, 0, null, $object);
          					complete_substitutions_array($substitutionarray, $outputlangs, $object);
          					$subjecttosend = make_substitutions($subject, $substitutionarray, $outputlangs);
          					$texttosend = make_substitutions(dol_concatdesc($msg, $adht->getMailOnSubscription()), $substitutionarray, $outputlangs);
          
          					// Attach a file ?
          					$file = '';
          					$listofpaths = array();
          					$listofnames = array();
          					$listofmimes = array();
          					if (is_object($object->invoice) && (!is_object($arraydefaultmessage) || intval($arraydefaultmessage->joinfiles))) {
          						$invoicediroutput = $conf->facture->dir_output;
          						$fileparams = dol_most_recent_file($invoicediroutput.'/'.$object->invoice->ref, preg_quote($object->invoice->ref, '/').'[^\-]+');
          						$file = $fileparams['fullname'];
          
          						$listofpaths = array($file);
          						$listofnames = array(basename($file));
          						$listofmimes = array(dol_mimetype($file));
          					}
          
          					$moreinheader = 'X-Dolibarr-Info: send_an_email by adherents/subscription.php'."\r\n";

I just can’t find the point in the source code where the payment method isn’t being transferred correctly from the invoice to the PDF being generated. Is it possible that the invoice object needs to be updated / fetched before the PDF is generated?

Best regards and thanks, Marcel