Payment link missing "ref" field

mancusoa · September 24, 2023, 5:12pm

Hi,
I just activated and configured Paypal and Stripe modules for payments.
I also enabled, in Settings/PDF, the flag to add into the invoice the payment link but when the link is generated the ref value is missing and the page shown says “Wrong parameters - ref” .
The invoice is Convalidated.

Example:
http://mycompany/public/payment/newpayment.php?source=invoice&ref=

I use Dolibarr 17.0.1
Thanks.

nsohani · November 11, 2023, 1:54am

I have similar issue, in version18.0.3. After validation of the invoice, the payment link created for Strip works fine, but the embedded url in the pdf invoice has the the same “Bad parameters - ref”, the url stops at ref. there is nothing beyond that like invoice number etc as is in the payment lin.

nsohani · November 12, 2023, 7:18pm

Look at this link

github.com/Dolibarr/dolibarr

stripe link related to generated invoice pdf

opened 03:35PM - 07 Sep 23 UTC

tanguychenier

Bug

### Bug in pdf_sponge_modules.php missing argument for the mode : `$paieme…nt_url = getOnlinePaymentUrl('', 'invoice', $object->ref, '', '', '');` ref will allways be null and printed pdf ref will too. Exemple: `$paiement_url = getOnlinePaymentUrl(0, 'invoice', $object->ref, '', '', '');` in core/libs/paiments.lib.php : ``` ... elseif ($type == 'invoice') { $out = $urltouse.'/public/payment/newpayment.php?source='.$type.'&ref='.($mode ? '<span style="color: #666666">' : ''); if ($mode == 1) { $out .= 'invoice_ref'; } if ($mode == 0) { $out .= urlencode($ref); } ``` actually : `$paiement_url = getOnlinePaymentUrl('', 'invoice', $object->ref, '', '', '');` The first argument to `getOnlinePaymentUrl` in `pdf_sponge_modules.php`, which is `$mode`, will never give a valid reference because `''` is defined and not an expected `$mode` defined by the `payment_url logic` in `pdf_sponge_modules.php` ### Environment Version 18.0.1 ### Environment OS Debian ### Environment Web server _No response_ ### Environment PHP 8.2.1 ### Environment Database _No response_ ### Environment URL(s) _No response_ ### Expected and actual behavior _No response_ ### Steps to reproduce the behavior _No response_ ### Attached files _No response_

nsohani · November 12, 2023, 10:15pm

With PHP Version 7.4, it works fine. With PHP V8.1 the stripe payment link on invoice stops at “ref” and give url does not work!

mancusoa · November 13, 2023, 10:27am

@nsohani Thanks for you reply and for the topic link.
So, do you suggest su downgrade to PHP v7.4?

nsohani · November 13, 2023, 9:10pm

I have tried several time PHP 8 and the payment link is incomplete. Same process I repeated with PHP 7.4. It worked all the time. the payment link printed on the PDF is complete and works! It could be the compatibility or Database Driver. I am using Maria Data base, which is fully compatible to Mysql.So try yourself rolling back to PHP 7.4